Move servicelb into cloudprovider

[brandond]

Proposed Changes

• Implement the newer, more efficient InstancesV2 interface which doesn't require us to get the node on our own
• Drop the InformerUser interface, since we are using InstancesV2 or Wrangler controllers and no longer make use of core Kubernetes shared informers.
• Move servicelb into cloudprovider and implement the LoadBalancer interface with the help of some Wrangler controllers to paper over holes in the upstream integrations. This appears to have been planned for upstream, as cloudprovider.ImplementedElsewhere can be returned most places to indicate a no-op status.
• Using the core LoadBalancer interface gives us all the normal Service events that other cloud providers expose, handles finalizers, and many other niceties that we were previously hand-rolling.
• Moving it into the cloud controller means we can easily enable it on RKE2 if we so desire.

Types of Changes

enhancement

Verification

Normal servicelb tests

Testing

Linked Issues

• Move servicelb into cloudprovider #6199

User-Facing Change

The ServiceLB (klipper-lb) service controller is now integrated into the K3s stub cloud controller manager.

Further Comments

[codecov-commenter]

Codecov Report

Base: 9.72% // Head: 9.76% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (1ff3682) compared to base (0d75d74).
Patch coverage: 1.86% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6181      +/-   ##
=========================================
+ Coverage    9.72%   9.76%   +0.04%     
=========================================
  Files         138     139       +1     
  Lines       10061   10100      +39     
=========================================
+ Hits          978     986       +8     
- Misses       8884    8912      +28     
- Partials      199     202       +3     

Flag	Coverage Δ
unittests	9.76% <1.86%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/cli/server/server.go	0.00% <0.00%> (ø)
pkg/cloudprovider/cloudprovider.go	0.00% <0.00%> (ø)
pkg/cloudprovider/instances.go	0.00% <0.00%> (ø)
pkg/cloudprovider/loadbalancer.go	0.00% <0.00%> (ø)
pkg/cloudprovider/servicelb.go	0.00% <0.00%> (ø)
pkg/daemons/agent/agent_linux.go	0.00% <0.00%> (ø)
pkg/daemons/config/types.go	64.91% <ø> (ø)
pkg/daemons/control/server.go	0.00% <0.00%> (ø)
pkg/daemons/executor/embed.go	2.08% <0.00%> (+0.12%)	⬆️
pkg/deploy/zz_generated_bindata.go	0.00% <ø> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[manuelbuil]

This is very nice! How could we use this in rke2? I guess by setting cloud=provider-external in kubelet but then we should somehow register this cloud-provider, right?

[brandond]

How could we use this in rke2

1. Update the k3s version in https://github.com/rancher/image-build-rke2-cloud-provider and cut a new tag with the changes
2. Update k3s in rke2
3. Update the rke2 CLI wrapper so that servicelb isn't always disabled
4. Update the rke2 RBAC helpers to sync the CCM RBAC changes from k3s
5. Update the rke2-cloud-provider image tag in rke2