-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: Groundwork for PR runs #6131
Conversation
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Codecov ReportBase: 9.72% // Head: 9.72% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
======================================
Coverage 9.72% 9.72%
======================================
Files 138 138
Lines 10057 10057
======================================
Hits 978 978
Misses 8880 8880
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The Drone tests will start and use a local image mirror if |
Signed-off-by: Derek Nola <[email protected]>
de4c6db
to
5629c06
Compare
@brandond This idea of using a cache is a much better solution. I have removed the docker login secret and moved to a docker registry running on the host. |
Signed-off-by: Derek Nola <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
89b94fb
to
4624d39
Compare
Proposed Changes
This PR address several issues that need to be resolved before we add E2E tests to PR checks.
CreateCluster
andCreateLocalCluster
to provision nodes in parallel. This improves test time significantly, provisioning the VMs previously was taking 40-60% of the runtime of a test. Testing on my local machine,validatecluster_test.go
went from10m29s
-->5m28s
. E2E Runners are much slower, but saw improvement from40m
->20m
.local
flag to validatecluster test. This allows the test to deploy a prebuild K3s binary, i.e. the binary associated with the PR. This test will be the first that gets converted to run on PRs. The remaining tests will be converted later.Ordered
tests. This has already been changed for integration tests. This bring the benefit of assuming that all It clauses should be run sequentially, and that an error in one causes any future It clauses to be skipped. Previously, It clauses would still run after the failure and usually fail as well. Reading GH logs on a failure is much easier.init.sh
andrun_test.sh
scripts which are deployed on E2E runnersTypes of Changes
Verification
All CI and E2E tests still pass.
Linked Issues
TBD
User-Facing Change
Further Comments