Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert codespell from Drone to GH actions #6004

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Aug 18, 2022

Signed-off-by: Derek Nola [email protected]

Proposed Changes

New version of codespell is finding more spelling errors, but also no longer just checking comments, but actual code.

  • Spelling mistake fixes
  • Codespell is now a GH action. This stops us from wasting valuable Drone time.

Types of Changes

Verification

Drone CI passes.
New GH Action Passes

Linked Issues

TBD

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner August 18, 2022 00:09
@dereknola dereknola changed the title FIx codespell CI Convert codespell from Drone to GH actions Aug 18, 2022
Copy link
Member

@cwayne18 cwayne18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dereknola
Copy link
Member Author

Drone ARM runners are failing due to unrelated issue.

@dereknola dereknola merged commit 035c03c into k3s-io:master Aug 18, 2022
brooksn pushed a commit to brooksn/k3s that referenced this pull request Aug 18, 2022
Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 035c03c)
brooksn pushed a commit to brooksn/k3s that referenced this pull request Aug 18, 2022
Signed-off-by: Derek Nola <[email protected]>
(cherry picked from commit 035c03c)
@dereknola dereknola deleted the codespell_fix branch August 18, 2022 21:17
nikolaishields pushed a commit to nikolaishields/k3s that referenced this pull request Sep 14, 2022
brandond pushed a commit to brandond/k3s that referenced this pull request Oct 6, 2022
brandond pushed a commit that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants