-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert codespell from Drone to GH actions #6004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
dereknola
force-pushed
the
codespell_fix
branch
from
August 18, 2022 00:36
501b796
to
dc5b503
Compare
dereknola
changed the title
FIx codespell CI
Convert codespell from Drone to GH actions
Aug 18, 2022
briandowns
approved these changes
Aug 18, 2022
galal-hussein
approved these changes
Aug 18, 2022
cwayne18
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Drone ARM runners are failing due to unrelated issue. |
brooksn
pushed a commit
to brooksn/k3s
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit 035c03c)
brooksn
pushed a commit
to brooksn/k3s
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Derek Nola <[email protected]> (cherry picked from commit 035c03c)
This was referenced Aug 18, 2022
nikolaishields
pushed a commit
to nikolaishields/k3s
that referenced
this pull request
Sep 14, 2022
Signed-off-by: Derek Nola <[email protected]> Signed-off-by: Nikolai Shields <[email protected]>
brandond
pushed a commit
to brandond/k3s
that referenced
this pull request
Oct 6, 2022
Signed-off-by: Derek Nola <[email protected]>
brandond
pushed a commit
that referenced
this pull request
Oct 7, 2022
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola [email protected]
Proposed Changes
New version of codespell is finding more spelling errors, but also no longer just checking comments, but actual code.
Types of Changes
Verification
Drone CI passes.
New GH Action Passes
Linked Issues
TBD
User-Facing Change
Further Comments