Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep existing tailscale subnet routes when deploying and deleting #8012

Open
manuelbuil opened this issue Jul 19, 2023 · 5 comments
Open

Keep existing tailscale subnet routes when deploying and deleting #8012

manuelbuil opened this issue Jul 19, 2023 · 5 comments
Milestone

Comments

@manuelbuil
Copy link
Contributor

manuelbuil commented Jul 19, 2023

Is your feature request related to a problem? Please describe.

When deploying k3s with tailscale, we are resetting the tailscale subnet routes and adding the ones required for flannel communication. Therefore, if a user is already operating tailscale with subnet routes, his/her traffic will get disrupted.

When removing, we are deleting all subnet-routes, so we should also find a way to fix this

Describe the solution you'd like

Before resetting, we should read the current subnet routes, save them, and then, after the reset add them back together with the new one for flannel

Describe alternatives you've considered

Additional context

@DCjanus
Copy link

DCjanus commented Aug 1, 2023

It seems that Tailscale does not appear to expose the interface of the current configuration. Is there any good way to solve this problem?

@manuelbuil
Copy link
Contributor Author

It seems that Tailscale does not appear to expose the interface of the current configuration. Is there any good way to solve this problem?

What do you mean by the interface of the current configuration? AFAIK, there is only one tailscale interface and if you change the config, that interface will use the new configuration

@DCjanus
Copy link

DCjanus commented Aug 1, 2023

Sorry for my mistake, I mean there is no API from tailscale to get current subroute config. And tailscale set would overwrite current subroutes.

I also encountered this issue. I tried to fix it, but I couldn't find a way to get the current subnet router.

@manuelbuil
Copy link
Contributor Author

Sorry for my mistake, I mean there is no API from tailscale to get current subroute config. And tailscale set would overwrite current subroutes.

I also encountered this issue. I tried to fix it, but I couldn't find a way to get the current subnet router.

I thought this output would return the subroute config https://github.com/k3s-io/k3s/blob/master/pkg/vpn/vpn.go#L123

@DCjanus
Copy link

DCjanus commented Aug 1, 2023

You are right, This is really good news.

@caroline-suse-rancher caroline-suse-rancher moved this from New to Backlog in K3s Development Aug 14, 2023
@caroline-suse-rancher caroline-suse-rancher added this to the Backlog milestone Aug 14, 2023
@manuelbuil manuelbuil changed the title Keep existing tailscale subnet routes when deploying Keep existing tailscale subnet routes when deploying and deleting Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Networking
Development

No branches or pull requests

3 participants