[Release-1.29] - K3s does not respect data-dir set via config file drop-in, or via env var

[brandond]

Backport fix for K3s does not respect data-dir set via config file drop-in, or via env var

• K3s does not respect data-dir set via config file drop-in, or via env var #10589

[ShylajaDevadiga]

Validated using k3s version v1.29.7-rc2+k3s1

Environment Details

Infrastructure
Cloud EC2 instance

Node(s) CPU architecture, OS, and Version:
Ubuntu 22.04

Cluster Configuration:
Single node

Results from validation the scenarios from the issue
Scenario 1:

# mkdir -p /etc/rancher/k3s; echo "data-dir: /k8s" >> /etc/rancher/k3s/config.yaml; curl -fL https://get.k3s.io| INSTALL_K3S_VERSION=v1.29.7-rc2+k3s1 INSTALL_K3S_CHANNEL=testing sh -s - server --cluster-init
# ls /k8s
agent  data  server

# K3S_DATA_DIR=/k8s k3s-uninstall.sh
# ls /k8s
ls: cannot access '/k8s': No such file or directory

Scenario 2:

curl -fL https://get.k3s.io| INSTALL_K3S_VERSION=v1.29.7-rc2+k3s1 INSTALL_K3S_CHANNEL=testing sh -s - server --cluster-init --data-dir=/k8s;
# ls /k8s
agent  data  server

# K3S_DATA_DIR=/k8s k3s-uninstall.sh
# ls /k8s
ls: cannot access '/k8s': No such file or directory

Scenario 3:

mkdir -p /etc/rancher/k3s/config.yaml.d; echo "data-dir: /k8s" >> /etc/rancher/k3s/config.yaml.d/99-data-dir.yaml;curl -fL https://get.k3s.io| INSTALL_K3S_VERSION=v1.29.7-rc2+k3s1 INSTALL_K3S_CHANNEL=testing sh -s - server --cluster-init
# ls /k8s
agent  data  server

# K3S_DATA_DIR=/k8s k3s-uninstall.sh
# ls /k8s
ls: cannot access '/k8s': No such file or directory

Scenario 4:

curl -fL https://get.k3s.io| K3S_DATA_DIR=/k8s INSTALL_K3S_VERSION=v1.29.7-rc2+k3s1 INSTALL_K3S_CHANNEL=testing sh -s - server --cluster-init
# ls /k8s
agent  data  server

# K3S_DATA_DIR=/k8s k3s-uninstall.sh
# ls /k8s
ls: cannot access '/k8s': No such file or directory