Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Switch back to cobra's StringArray flag #473

Closed
iwilltry42 opened this issue Feb 3, 2021 · 1 comment
Closed

[FEATURE] Switch back to cobra's StringArray flag #473

iwilltry42 opened this issue Feb 3, 2021 · 1 comment
Assignees
@iwilltry42
Labels
dependency Issue concerns some dependency or external library/module enhancement New feature or request priority/high scope/cli Issue concerns the CLI (cmd/)
Milestone
Backlog

Comments

@iwilltry42
Copy link
Member

As of v4.1.0, we're using cobra's StringSlice flags for repeatable flags, so that it works with viper's GetStringSlice function.
However, this splits flag values into different slice parts, even if it's a single part.
E.g. --env X=a,b,c would be treated the same as --env X=a, --env b, --env c

We should revert to StringArray type flags once spf13/viper#246 and spf13/viper#398 are resolved.
@iwilltry42 iwilltry42 added the enhancement New feature or request label Feb 3, 2021
@iwilltry42 iwilltry42 self-assigned this Feb 3, 2021
@iwilltry42 iwilltry42 added this to the v4.2.0 milestone Feb 5, 2021
@iwilltry42 iwilltry42 mentioned this issue Mar 8, 2021
Closed
@iwilltry42 iwilltry42 modified the milestones: v4.3.0, v4.4.0 Mar 10, 2021
@iwilltry42
Copy link
Member Author

Fix included in viper fork is included in v4.4.1-rc.0 (reverting from fork to upstream, as soon as the fix is merged there): https://github.com/rancher/k3d/releases/tag/v4.4.1-rc.0

@iwilltry42 iwilltry42 added dependency Issue concerns some dependency or external library/module scope/cli Issue concerns the CLI (cmd/) labels Apr 1, 2021
@iwilltry42 iwilltry42 modified the milestones: v4.4.5, Backlog Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwilltry42 iwilltry42

Labels
dependency Issue concerns some dependency or external library/module enhancement New feature or request priority/high scope/cli Issue concerns the CLI (cmd/)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@iwilltry42