You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we're using the standard logging library and at some points at the code we check for the --verbose flag, while at other points we don't.
Also we don't have any sorts of log level (just print or fatal) between which we could switch.
Additionally, the log messages differ highly from each other.
Bonus: our error handling is quite mixed... at some level we pass the error upstream, sometimes we drop out with a Fatalf or we simply log something and go on. This could be approved e.g. in a way that we only drop out of the process at the top-most level and have lower-level functions only returning meaningful errors.
It would be nice if we could
clean up the log messages to a unified format
introduce a more feature-rich logging library (e.g. sirupsen/logrus)
Get proper unified error handling
The text was updated successfully, but these errors were encountered:
Currently we're using the standard logging library and at some points at the code we check for the
--verbose
flag, while at other points we don't.Also we don't have any sorts of log level (just print or fatal) between which we could switch.
Additionally, the log messages differ highly from each other.
Bonus: our error handling is quite mixed... at some level we pass the error upstream, sometimes we drop out with a
Fatalf
or we simply log something and go on. This could be approved e.g. in a way that we only drop out of the process at the top-most level and have lower-level functions only returning meaningful errors.It would be nice if we could
The text was updated successfully, but these errors were encountered: