Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Proper logging and error handling #17

Closed
2 of 3 tasks
iwilltry42 opened this issue Apr 26, 2019 · 1 comment
Closed
2 of 3 tasks

[Enhancement] Proper logging and error handling #17

iwilltry42 opened this issue Apr 26, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iwilltry42
Copy link
Member

iwilltry42 commented Apr 26, 2019

Currently we're using the standard logging library and at some points at the code we check for the --verbose flag, while at other points we don't.
Also we don't have any sorts of log level (just print or fatal) between which we could switch.
Additionally, the log messages differ highly from each other.

Bonus: our error handling is quite mixed... at some level we pass the error upstream, sometimes we drop out with a Fatalf or we simply log something and go on. This could be approved e.g. in a way that we only drop out of the process at the top-most level and have lower-level functions only returning meaningful errors.

It would be nice if we could

  • clean up the log messages to a unified format
  • introduce a more feature-rich logging library (e.g. sirupsen/logrus)
  • Get proper unified error handling
@iwilltry42 iwilltry42 added enhancement New feature or request good first issue Good for newcomers labels Apr 26, 2019
@iwilltry42 iwilltry42 changed the title [Feature] Proper logging and error handling [Enhancement] Proper logging and error handling Apr 26, 2019
@iwilltry42 iwilltry42 added this to the v2.0 milestone Jun 11, 2019
@iwilltry42 iwilltry42 modified the milestones: v2.0, v3.0 - big refactoring Sep 4, 2019
@iwilltry42
Copy link
Member Author

Better logging introduced by @nlamirault . Postponing new error handling until next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant