Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a wrong file name? #505

Closed
JaheimLee opened this issue Jul 28, 2022 · 3 comments
Closed

Is it a wrong file name? #505

JaheimLee opened this issue Jul 28, 2022 · 3 comments

Comments

@JaheimLee
Copy link

S subset name seems has an extra name "test", but L and M subset doesn't.

split_dir=data/fbank/S_split_${num_splits}_test

@csukuangfj
Copy link
Collaborator

@JaheimLee
Yes, I think you are right.

The following code assumes that the name is S_split_${num_splits}. We should remove _test.

output_dir = f"data/fbank/{subset}_split_{num_splits}"

Could you make a PR to do that?

cc @luomingshuang

@luomingshuang
Copy link
Collaborator

Oh,sorry. You're right. Thanks.

@luomingshuang
Copy link
Collaborator

I have done a correction for this. #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants