Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline zipformer2, timestamp for first token is always 0 #1347

Closed
joazoa opened this issue Oct 27, 2023 · 3 comments
Closed

offline zipformer2, timestamp for first token is always 0 #1347

joazoa opened this issue Oct 27, 2023 · 3 comments

Comments

@joazoa
Copy link

joazoa commented Oct 27, 2023

Hello,

I still experience the issue where the first word timestamp is aways zero with the onnx zipformer2.

I have seen the comments in :
#942
#923
k2-fsa/sherpa#52

Is there any way to avoid this with the zipformer2 ? I tried without onnx and the result is the same. Is the same, there is no padding_idx=blank_id in the decoder as in the decoders patched in the commit above.

Would the zipformer_CTC that was committed earlier today have the same issue ?

I have vague memories of another issue or pull request where [csukuangfj] made a more detailed analysis for another model (I think transducer_stateless ) that did not have the issue, but cannot find those comments anymore.

Thank you!

@joazoa joazoa changed the title offline onnx zipformer2, timestamp for first token is always 0 offline zipformer2, timestamp for first token is always 0 Oct 27, 2023
@maltium
Copy link

maltium commented Oct 31, 2023

The patch didn't really fix the issue in the original zipformer. Maybe it improved it, but when I did some testing I was still getting 0 timestamps for the first token.

@joazoa
Copy link
Author

joazoa commented Nov 3, 2023

Thank you! I see a few samples with 0,04 but mostly 0. I checked with padded samples with large silence in the beginning and it did not detect it.

@joazoa joazoa closed this as completed Nov 3, 2023
@joazoa joazoa reopened this Nov 3, 2023
@joazoa joazoa closed this as completed Nov 3, 2023
@maltium
Copy link

maltium commented Nov 3, 2023

@joazoa I'm just a user of icefall sharing my experience. You should probably keep the issue open 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants