Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize call responsibilities for expr.Eval #141

Closed
k2tzumi opened this issue Sep 11, 2022 · 2 comments
Closed

Organize call responsibilities for expr.Eval #141

k2tzumi opened this issue Sep 11, 2022 · 2 comments

Comments

@k2tzumi
Copy link
Collaborator

k2tzumi commented Sep 11, 2022

The logic to evaluate an expression against a store is duplicated in several programs.

We are dealing directly with the antonmedv/expr library, which we believe is problematic for unified expression expansion.

I think we need to organize the use cases for the process of evaluating expressions, clarify who is in charge of the logic, and do some refactoring.

@k1LoW
Copy link
Owner

k1LoW commented Oct 5, 2022

Hi @k2tzumi

We have integrated the functions related to the expr package in eval.go

I think this has achieved a certain level of success, but what do you think?

@k2tzumi
Copy link
Collaborator Author

k2tzumi commented Oct 5, 2022

@k1LoW

Yes. I think we have been able to integrate.
Thank you for your response!

@k2tzumi k2tzumi closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants