Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--data-dir gets doubled-up when used as installFlag #527

Closed
rwos opened this issue Aug 4, 2023 · 0 comments · Fixed by #538
Closed

--data-dir gets doubled-up when used as installFlag #527

rwos opened this issue Aug 4, 2023 · 0 comments · Fixed by #538
Labels
bug Something isn't working

Comments

@rwos
Copy link

rwos commented Aug 4, 2023

a config such as

apiVersion: k0sctl.k0sproject.io/v1beta1
kind: Cluster
metadata:
  name: runway-testing
spec:
  hosts:
  ...
  - role: worker
    installFlags:
      - --data-dir /something

will result in, e.g., a k0sctl apply running commands like

INFO[0010] [ssh] 10.1.2.3:22: installing k0s worker 
DEBU[0010] [ssh] 10.1.2.3:22: executing `sudo -s -- /opt/bin/k0s install worker --data-dir='--data-dir /something' --token-file "/etc/k0s/k0stoken"` 

which doesn't work all that well :)

I'm not 100% certain this would fix it but I think .Get here should be .GetValue - https://github.com/k0sproject/k0sctl/blame/c4e776e70a3d03c8b545845132b2a21392d979fa/pkg/apis/k0sctl.k0sproject.io/v1beta1/cluster/host.go#L71C6-L71C6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants