Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics when used as a go package #505

Closed
kke opened this issue Jun 21, 2023 · 4 comments · Fixed by #507
Closed

Analytics when used as a go package #505

kke opened this issue Jun 21, 2023 · 4 comments · Fixed by #507
Labels
enhancement New feature or request

Comments

@kke
Copy link
Contributor

kke commented Jun 21, 2023

One way to disable analytics would be to set segment.WriteKey to "" before reusing phases, but forgetting to do so would make the 3rd party app send k0sctl telemetry.

The best fix is probably to move the segment write key into the initAnalytics function used by cli commands. Or to remove analytics, nobody looks at them.

@kke kke added the enhancement New feature or request label Jun 21, 2023
@kke
Copy link
Contributor Author

kke commented Jun 21, 2023

I think @alessiodionisi 's terraform provider for example is secretly sending k0sctl analytics to segment.

@jnummelin
Copy link
Member

hmm, what if we "inject" the key via buildflags only on the official k0sctl builds?

@kke
Copy link
Contributor Author

kke commented Jun 21, 2023

Then it's not there for homebrew (unless it's added into the brew-formula), that's why it was hardcoded. A similar problem as for k0sctl version in #479

@jnummelin
Copy link
Member

right 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants