Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not accept -c or --config option for the worker subcommand #1222

Closed
mikhail-sakhnov opened this issue Oct 27, 2021 · 4 comments · Fixed by #1389
Closed

Do not accept -c or --config option for the worker subcommand #1222

mikhail-sakhnov opened this issue Oct 27, 2021 · 4 comments · Fixed by #1389
Labels
area/cli bug Something isn't working

Comments

@mikhail-sakhnov
Copy link
Contributor

while we don't use config in the worker process we still accept it as a cli argument which makes CLI interface confusing

@mikhail-sakhnov mikhail-sakhnov added bug Something isn't working area/cli labels Oct 27, 2021
@kke
Copy link
Contributor

kke commented Oct 28, 2021

There's some other flags returned with the GetPersistentFlagSet that are not needed where it is used. Also, it is used in "intermediary" sub-commands such as k0s token, which by itself does nothing and should not have any flags apart from --help.

@kke
Copy link
Contributor

kke commented Oct 28, 2021

Then what about the etcd mid-command? There's some storage-type checking code in the k0s etcd but as far as I can tell, it will never execute (changing storage type to sqlite and doing k0s etcd leave does not seem to complain about storage type, maybe it does on otherwise working config with a running cluster, not sure)

@jnummelin
Copy link
Member

jnummelin commented Dec 20, 2021

Should be fixed with #1247

@trawler
Copy link
Contributor

trawler commented Dec 29, 2021

fixed with #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bug Something isn't working
Projects
None yet
4 participants