Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config CRD: use combined config object instead of node/cluster config #1208

Closed
trawler opened this issue Oct 22, 2021 · 2 comments · Fixed by #1409
Closed

Config CRD: use combined config object instead of node/cluster config #1208

trawler opened this issue Oct 22, 2021 · 2 comments · Fixed by #1409
Labels
bug Something isn't working Stale

Comments

@trawler
Copy link
Contributor

trawler commented Oct 22, 2021

Currently k0s API config uses node config, fed from a config-file flag, and cluster-config, derived from a CR.
This is causing unneeded complexity in the code, where different commands expecting to fetch a certain attribute is not fetching the right kind of config.
We should think and discuss an alternative method and merge the two kinds of configuration.
@trawler trawler added the bug Something isn't working label Oct 22, 2021
@jnummelin jnummelin linked a pull request Dec 20, 2021 that will close this issue
pkg/config: refactoring config handling #1247
Closed
@jnummelin
Copy link
Member

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot removed the Stale label Dec 23, 2021
@trawler trawler linked a pull request Jan 11, 2022 that will close this issue
config refactoring: use runtime config #1409
Merged
3 tasks
@trawler trawler removed a link to a pull request Jan 11, 2022
pkg/config: refactoring config handling #1247
Closed
@github-actions
Copy link
Contributor

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config refactoring: use runtime config trawler/k0s
2 participants
@jnummelin @trawler