Skip to content
This repository has been archived by the owner on Sep 30, 2021. It is now read-only.

Jump to the comment for the comment link #1013

Closed
zvirja opened this issue Sep 26, 2017 · 14 comments
Closed

Jump to the comment for the comment link #1013

zvirja opened this issue Sep 26, 2017 · 14 comments

Comments

@zvirja
Copy link

zvirja commented Sep 26, 2017

FastHub Version: 4.3.0
Android Version: 7.0 (SDK: 24)
Device Information:

  • Manufacturer: samsung
  • Brand: samsung
  • Model: Galaxy Tab S2 8.0

Currently when you have a link to the comment, FastHub opens the thread only, however doesn't jump to the comment itself. Consider this link as example: AutoFixture/AutoFixture#842 (comment). While the thread is opened, you have no clue which particular comment is referenced.

If you open this link in a browser, it will jump and highlight the comment.

This is very important feature and I feel the pain of its absence almost every day. 😢

The overall experience becomes even worse, because FastHub application intercept links to the github. Therefore, when I receive an email from GitHub and want to jump to the comment, link is opened in the app, rather than in the browser and I should find the comment manually.

Please please please add this feature :) Also don't forget about paging and highlighting of the comment, so you clearly see which exact one has been pointed.

Thank you! 🙌

@zvirja
Copy link
Author

zvirja commented Sep 26, 2017

Link to the duplicated issue please 😊

@k0shk0sh
Copy link
Owner

could u search for it? my internet is shitty

@zvirja
Copy link
Author

zvirja commented Sep 26, 2017

I've reviewed opened issues for 3 times, but cannot see it. Please post a link when your Internet is OK back again 😉

@k0shk0sh
Copy link
Owner

and please Alex, search for the issue before opening new one, as much as I appreciate your efforts, but I want you to make an extra step in your effort to search ?

@yakov116
Copy link
Collaborator

@k0shk0sh @zvirja #988 is the one I found

@k0shk0sh
Copy link
Owner

there are more, closed ones.

@zvirja
Copy link
Author

zvirja commented Sep 26, 2017

@yakov116 This one is closed.

and please Alex, search for the issue before opening new one

While I may admit that sometimes I post duplicates, this time I'm unable to see the opened issues about this feature. Therefore, I honestly searched through the list of opened issues, found nothing and registered this one. Probably, I missed something.

In any case, next time will try to search more thoroughly before opening the issue.

@k0shk0sh
Copy link
Owner

thanks man and sorry if I'm asking for too much, they are closed matter of fact because I remembered last time I wasn't gonna implement it. I'll look for the first one and reopen tomorrow.

@zvirja
Copy link
Author

zvirja commented Sep 28, 2017

@k0shk0sh Have you reopened any issue? Just want to ensure that we haven't forgot about the issue..

@zvirja
Copy link
Author

zvirja commented Oct 13, 2017

@k0shk0sh Could you please either re-open this issue or the similar one? This is a really missing feature and I luck it each day... 😢

@zvirja
Copy link
Author

zvirja commented Oct 17, 2017

@k0shk0sh Are you here? 😉 Just want to ensure that we don't miss the feature and it's in backlog..

@yakov116
Copy link
Collaborator

@k0shk0sh no he is in another world 💤

@k0shk0sh
Copy link
Owner

ignore:

jashkenas/underscore#1805 (comment)

second page: jashkenas/underscore#1805 (comment)

@yakov116
Copy link
Collaborator

@k0shk0sh can we highlight the comment like you do when going to a specific
Iine in code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants