Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Available Markets #98

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Get Available Markets #98

merged 3 commits into from
Aug 3, 2024

Conversation

eleonora2687
Copy link
Contributor

@eleonora2687 eleonora2687 commented Jul 11, 2024

No description provided.

@jzheng2017
Copy link
Owner

jzheng2017 commented Jul 11, 2024

Looks good overall but please fix the whitespace formatting in general for all the files. In addition to that write unit tests for the added functionality. See the existing tests for reference. Lastly, fix the commit messages/PR, as they should follow the guidelines as specified in https://github.com/jzheng2017/spotify-web-api-wrapper/blob/main/CONTRIBUTING.md#git-guidelines

public class MarketFull {

private List<String> markets = new ArrayList<String>() ;
public List<String> getAllMarkets() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer getMarkets

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the whitespace formatting please.


public class MarketFull {

private List<String> markets = new ArrayList<String>() ;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ArrayList instantiation

@eleonora2687
Copy link
Contributor Author

Looks good overall but please fix the whitespace formatting in general for all the files. In addition to that write unit tests for the added functionality. See the existing tests for reference. Lastly, fix the commit messages/PR, as they should follow the guidelines as specified in https://github.com/jzheng2017/spotify-web-api-wrapper/blob/main/CONTRIBUTING.md#git-guidelines

Not quite sure about the tests(if i should add another test/s) and the commit messages/PR

@eleonora2687
Copy link
Contributor Author

Can you please check the changes i made (whenever you get the time) and let me know what else should i do next?
i've put A LOT of effort to make all this(the project is big and it it very easy to "get lost" here trying to adapt things here 😓

Thanks in advance

@jzheng2017
Copy link
Owner

Can you please check the changes i made (whenever you get the time) and let me know what else should i do next? i've put A LOT of effort to make all this(the project is big and it it very easy to "get lost" here trying to adapt things here 😓

Thanks in advance

Thanks. I've been a bit busy so I haven't been able to check. I will review the PR soon. Thanks for the patience.

@jzheng2017
Copy link
Owner

jzheng2017 commented Aug 1, 2024

PR looks great with no additional comments. Approved for now. I will test it this week and if it works fine then it can be merged.

@jzheng2017
Copy link
Owner

I have tested this PR and it works without any issue. It's okay for merge. Thank you for your work.

@jzheng2017 jzheng2017 merged commit 9689290 into jzheng2017:main Aug 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants