-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Available Markets #98
Conversation
Looks good overall but please fix the whitespace formatting in general for all the files. In addition to that write unit tests for the added functionality. See the existing tests for reference. Lastly, fix the commit messages/PR, as they should follow the guidelines as specified in https://github.com/jzheng2017/spotify-web-api-wrapper/blob/main/CONTRIBUTING.md#git-guidelines |
public class MarketFull { | ||
|
||
private List<String> markets = new ArrayList<String>() ; | ||
public List<String> getAllMarkets() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer getMarkets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the whitespace formatting please.
|
||
public class MarketFull { | ||
|
||
private List<String> markets = new ArrayList<String>() ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the ArrayList instantiation
Not quite sure about the tests(if i should add another test/s) and the commit messages/PR |
Can you please check the changes i made (whenever you get the time) and let me know what else should i do next? Thanks in advance |
Thanks. I've been a bit busy so I haven't been able to check. I will review the PR soon. Thanks for the patience. |
PR looks great with no additional comments. Approved for now. I will test it this week and if it works fine then it can be merged. |
I have tested this PR and it works without any issue. It's okay for merge. Thank you for your work. |
No description provided.