Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node version 20 #79

Open
poldenburg opened this issue Nov 20, 2024 · 6 comments
Open

Add support for Node version 20 #79

poldenburg opened this issue Nov 20, 2024 · 6 comments

Comments

@poldenburg
Copy link

Renovate 38 requires node version 20.
Can you update the extension to support this node version?

@jycouet
Copy link
Owner

jycouet commented Nov 20, 2024

What is needed to support it ?

@poldenburg
Copy link
Author

I'm not sure, maybe only update the node version, like in PR #69

@poldenburg
Copy link
Author

@jycouet do you have time to look into this?

@jycouet
Copy link
Owner

jycouet commented Dec 11, 2024

I just released a version 1.0.6, close the ticket if it's working :)

@jycouet jycouet reopened this Dec 11, 2024
@poldenburg
Copy link
Author

Great, thanks! The extension has been updated, but the pipeline still uses the old version (1.0.5), seems like a caching issue. I'll check again after the weekend.

@poldenburg
Copy link
Author

@jycouet: Tested and working perfectly, thanks again!

A few comments:

  • The task still shows version 1.0.5, because in task.json the Patch version wasn't updated to 6
  • In the README NodeTool@0 is used. I suggest updating this to UseNode@1
  • The task throws some warnings about deprecated packages, so maybe you could update the dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants