Add RSS plugin and feed link #99
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6e85145 in 10 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. mkdocs.yml:157
- Draft comment:
The RSS feed link should be an absolute URL to ensure it works correctly across different contexts. Consider updating it to an absolute URL. - Reason this comment was not posted:
Confidence changes required:80%
The PR adds the RSS plugin to the mkdocs configuration and the requirements file. However, the link to the RSS feed in the social section should be an absolute URL to ensure it works correctly.
2. requirements-doc.txt:7
- Draft comment:
Ensure that themkdocs-rss-pluginis correctly installed and compatible with the current setup. - Reason this comment was not posted:
Confidence changes required:50%
The addition of the RSS plugin in the requirements file is correct and necessary for the functionality added in the PR.
Workflow ID: wflow_tpQX5bHkLNh6mGU7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59
Was recommended your blog and wanted to subscribe via RSS, and the plugin seemed simple enough to implement so figured I'd contribute.
XML documents representing the feed should be generated at build time (one for updates one for creations), and the link at the bottom should link to the creation version (
feed_rss_created.xml).Let me know if any additional changes are necessary, and thank you!
Important
Add RSS plugin to MkDocs and link to RSS feed in social links.
rssplugin tomkdocs.ymlto generate RSS feeds.requirements-doc.txtto includemkdocs-rss-plugin.feed_rss_created.xml) to social links inmkdocs.yml.This description was created by
for 6e85145. It will automatically update as commits are pushed.