feat: allow deleting branches with 'd' (with a confirmation prompt) #541
Conversation
|
Any chance you could take a look here @jwu910 some time soon? |
|
Hi thanks for opening up this PR. I've been incredibly busy and may not have time to review soon. Im also still on the fence whether or not the functionality is going to be necessary, and may want to consider brainstorming how this could potentially be an extension similar to the extra Git log commands we have in place. If a user can add to the config store an array of commands, we can hide this behind a flag and or user defined option to allow for deleting Let me try to think about this a bit too, but definitely appreciate this PR opening up |
|
Hey @jwu910 thanks for getting back to me. Yep no worries then. Have a think and let me know what you end up deciding. |
| if (state.currentRemoteIndex !== 0) { | ||
| logger.error("Branch deletion is only available on heads"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Bah there's a bug here as heads might not be index 0 always. So IF we decide to go ahead with this approach, I'll fix this up
fix #530
Description
This PR adds delete functionality by typing in
dwhen on the heads remote. The user is prompted to enteryto confirm deletion and exits successfully after deleting the branch (similar to selecting a branch to avoid stale info being shown to the user).Types of changes
Checklist: