Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the custom Base64 encode and decode to favour the built-in methods #551

Closed
anakinj opened this issue Feb 2, 2023 · 1 comment
Closed

Drop the custom Base64 encode and decode to favour the built-in methods #551

anakinj opened this issue Feb 2, 2023 · 1 comment
Milestone
Version 3.0

Comments

@anakinj
Copy link
Member

anakinj commented Feb 2, 2023

We currently use a custom implementation of the urlsafe encode and decode methods because switching to the Base64.urlsafe_decode64 and Base64.urlsafe_encode64 introduced a few issues (#483).

Think the only practical impact is that the token cannot have trailing spaces anymore.
@anakinj anakinj added this to the Version 3.x milestone Feb 2, 2023
@anakinj anakinj mentioned this issue Dec 28, 2023
Closed
2 tasks
@anakinj
Copy link
Member Author

anakinj commented Dec 28, 2024 •
edited
Loading

Only stricter base64 decode supported via #658

@anakinj anakinj closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
1 participant
@anakinj