Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aud verifies if aud is passed in, :sub does not #102

Closed
skippy opened this issue Sep 16, 2015 · 1 comment
Closed

aud verifies if aud is passed in, :sub does not #102

skippy opened this issue Sep 16, 2015 · 1 comment
Labels

Comments

@skippy
Copy link
Contributor

skippy commented Sep 16, 2015

If you pass in :aud and :verify_aud, then it will fail if :aud is not in the payload.

the equivalent is not true for :sub. If you pass in :sub but it is not in the payload, it won't do anything. I would expect the behavior of :aud, which is if you ask to verify_sub, it will fail if it isn't in the payload.

if that sounds reasonable, I'll submit a patch. thanks!

@excpt
Copy link
Member

excpt commented Sep 17, 2015

It should behave like the :aud validation.

@excpt excpt added the bug label Sep 17, 2015
@excpt excpt added this to the Version 2.0.0 milestone Sep 17, 2015
@excpt excpt closed this as completed Sep 17, 2015
@anakinj anakinj removed this from the Version 3.0.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants