Skip to content

Commit

Permalink
bugfix/test - update Jest configuration to fix unit tests (usebruno#2672
Browse files Browse the repository at this point in the history
)
  • Loading branch information
pietrygamat authored and jwetzell committed Aug 2, 2024
1 parent d2db2b0 commit 47510df
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 22 deletions.
3 changes: 3 additions & 0 deletions packages/bruno-electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
"pack": "electron-builder --dir",
"test": "jest"
},
"jest": {
"modulePaths": ["node_modules"]
},
"dependencies": {
"@aws-sdk/credential-providers": "3.525.0",
"@usebruno/common": "0.1.0",
Expand Down
34 changes: 12 additions & 22 deletions packages/bruno-electron/tests/network/index.spec.js
Original file line number Diff line number Diff line change
@@ -1,25 +1,15 @@
// damn jest throws an error when no tests are found in a file
// --passWithNoTests doesn't work
const { configureRequest } = require('../../src/ipc/network/index');

describe('dummy test', () => {
it('should pass', () => {
expect(true).toBe(true);
describe('index: configureRequest', () => {
it("Should add 'http://' to the URL if no protocol is specified", async () => {
const request = { method: 'GET', url: 'test-domain', body: {} };
await configureRequest(null, request, null, null, null, null);
expect(request.url).toEqual('http://test-domain');
});
});

// todo: fix this failing test
// const { configureRequest } = require('../../src/ipc/network/index');

// describe('index: configureRequest', () => {
// it("Should add 'http://' to the URL if no protocol is specified", async () => {
// const request = { method: 'GET', url: 'test-domain', body: {} };
// await configureRequest(null, request, null, null, null, null);
// expect(request.url).toEqual('http://test-domain');
// });

// it("Should NOT add 'http://' to the URL if a protocol is specified", async () => {
// const request = { method: 'GET', url: 'ftp://test-domain', body: {} };
// await configureRequest(null, request, null, null, null, null);
// expect(request.url).toEqual('ftp://test-domain');
// });
// });
it("Should NOT add 'http://' to the URL if a protocol is specified", async () => {
const request = { method: 'GET', url: 'ftp://test-domain', body: {} };
await configureRequest(null, request, null, null, null, null);
expect(request.url).toEqual('ftp://test-domain');
});
});

0 comments on commit 47510df

Please sign in to comment.