Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessible/accessable option removed? #69

Open
piotrkulpinski opened this issue Mar 9, 2016 · 4 comments
Open

accessible/accessable option removed? #69

piotrkulpinski opened this issue Mar 9, 2016 · 4 comments

Comments

@piotrkulpinski
Copy link

Hi guys,
Just wanted to check with you if you got rid of the accessible option? I have some form element I'd like to have accessible for user when walkthrough is displayed and I wonder if there's a way to do that with current version?

Thanks

@piotrkulpinski
Copy link
Author

This was probably removed in #35 but please confirm.
I'd love to have such option back if possible.

@jwarby
Copy link
Owner

jwarby commented Mar 10, 2016

We actually removed this in 05e8d9f, to fix a couple of other bugs (#30 and #21). In that commit, we simplified the plugin and removed alot of complicated logic for "boxing in" the highlighted element (we fitted a transparent overlay over the highlighted element, and used box-shadows combined with a fullscreen dark overlay).

The intention was to re-introduce the accesibility feature at some point (see #42), but we never got around to it. We've also been planning to do a full rewrite (v3) of the project for a while, but again, haven't got round to it.

With the way it's setup now, there's no way for us to re-implement this feature without changing most of the plugin's code, so we'd probably be better off doing the full rewrite and implementing it at that point.

@piotrkulpinski
Copy link
Author

I understand, that's what I thought.
Anyway, thanks for the response and for the ongoing development of this plugin.

@jwarby
Copy link
Owner

jwarby commented Mar 10, 2016

No worries, sorry I can't help any further at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants