Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use AnnData #56

Closed
jvivian opened this issue Mar 5, 2024 · 1 comment
Closed

Refactor to use AnnData #56

jvivian opened this issue Mar 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical

Comments

@jvivian
Copy link
Owner

jvivian commented Mar 5, 2024

Not sure if when we'll do this, but had a thought going to bed last night that we could simplify the model input and clean up the code by decoupling things like factor specification from the inputs (i.e. why are factors hardcoded ? What if someone else wants to use different factors without needing to use the python package directly and override factors when calling the model? What if they have different data? Etc)

We'd do this by converting the input into an Anndata object:

https://anndata.readthedocs.io/en/latest/

X - Matrix contains numeric data
obs matrix contains info like Time, State for each observation
var matrix contains information about variables, such as alternate name, factor assignment, etc.)

So the input could be generalized to that input (or for general users), 2-3 Excel files, one for each matrix.

@jvivian jvivian added enhancement New feature or request medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical labels Mar 5, 2024
@jvivian jvivian self-assigned this Mar 8, 2024
@jvivian
Copy link
Owner Author

jvivian commented Mar 23, 2024

Going to try and implement this today if I can. This will almost assuredly cause merge conflicts for anyone working on code that touches processing.py or Dashboard.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium difficulty a bit more challenging than "good first issue" This Pleases The John Stuff John really wants (usually idiomatic refactoring) but isn't critical
Projects
None yet
Development

No branches or pull requests

1 participant