Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force user to use node 8.x to use util.promisify #276

Open
aelbore opened this issue Jan 31, 2018 · 6 comments
Open

force user to use node 8.x to use util.promisify #276

aelbore opened this issue Jan 31, 2018 · 6 comments

Comments

@aelbore
Copy link

aelbore commented Jan 31, 2018

since 8.x is the LTS version for node, why not change the promisify function to require('util').promisify

@aelbore aelbore changed the title force user to use node 8.x to use util.promify force user to use node 8.x to use util.promisify Jan 31, 2018
@jvandemo
Copy link
Owner

jvandemo commented Feb 4, 2018

@aelbore — What would be the benefit from a user's perspective? I'm guessing some people still use node v6. What would be the benefit of forcing them to use node v8? Thanks in advance!

@aelbore
Copy link
Author

aelbore commented Feb 6, 2018

@jvandemo i notice that your using promisify to make the fs.readfile to promise, and also since node v8 is the LTS version in a few months theres no support for v6.
async/await to make code shorter.

@aelbore
Copy link
Author

aelbore commented Feb 6, 2018

@jvandemo by the way i got lightweight cli to bundle angular as a package. you might consider this also.
https://github.com/ngx-devtools/cli
or just npm install -g @ngx-devtools/cli
then ngx run bundle
thanks.

@izifortune
Copy link
Collaborator

I wouldn't see any problems about dropping the support for node v6

@jvandemo
Copy link
Owner

@aelbore — Would you be interested in creating a PR to update the code to node v8? Thanks!

@aelbore
Copy link
Author

aelbore commented Mar 13, 2018

@jvandemo sure will create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants