-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force user to use node 8.x to use util.promisify #276
Comments
@aelbore — What would be the benefit from a user's perspective? I'm guessing some people still use node v6. What would be the benefit of forcing them to use node v8? Thanks in advance! |
@jvandemo i notice that your using promisify to make the fs.readfile to promise, and also since node v8 is the LTS version in a few months theres no support for v6. |
@jvandemo by the way i got lightweight cli to bundle angular as a package. you might consider this also. |
I wouldn't see any problems about dropping the support for node v6 |
@aelbore — Would you be interested in creating a PR to update the code to node v8? Thanks! |
@jvandemo sure will create a PR :) |
since 8.x is the LTS version for node, why not change the promisify function to require('util').promisify
The text was updated successfully, but these errors were encountered: