Update iTerm script

[kevintraver]

iTerm2 made some changes to its scripting, which causes 'got' to silently fail when using iTerm2, and setting
let g:gtfo#terminals = { 'mac' : 'iterm' }

Here is the new scripting commands:
https://github.com/gnachman/iTerm2/blob/master/iTerm2.sdef

Perhaps it might be necessary to check and have separate scripts for iTerm/iTerm2.
Thoughts?

[justinmk]

Thanks for digging into this. Are you saying it doesn't work for older iTerm2 releases?

With your changes, what's the behavior if you are in, say, MacVim? Does got bring iTerm2 to the foreground (it should)?

[kevintraver]

Yes the functionality appears to be the same. And yes, this would break old releases.

On a related note, it seems it might be possible to drop applescript all together.

Calling the system command works just fine even with iterm:

silent call system("open -a ".s:termpath." '".l:dir."'")

[justinmk]

Dropping applescript would be great.

silent call system("open -a ".s:termpath." '".l:dir."'")

Does that work for the following cases:

• if iterm isn't running, it starts iterm and focuses the new terminal
• if iterm is running but not focused (e.g. if user is using MacVim), it focuses iterm and creates a new tab
• if iterm is running and focused it creates a new tab

[kevintraver]

Yes, it works for all those cases.

[justinmk]

Need a line above this for the empty case, similar to line 144:

if s:empty(s:termpath) | let s:termpath = 'iTerm.app' | endif

[justinmk]

Oops, that will break on the next invocation (because s:termpath is no longer empty). Instead, it can just be:

     if (s:empty(s:termpath) && $TERM_PROGRAM ==? 'iTerm.app') || s:termpath ==? "iterm"
       silent call system("open -a iTerm '".l:dir."'")

[justinmk]

@kevintraver Thanks. Can you squash to 1 commit?

[justinmk]

Thanks!