gtfo does not support opening terminal on MacOS not using open -a

[andrewferrier]

It seems, inspecting the code (

vim-gtfo/autoload/gtfo/open.vim

Line 176 in d89d333

silent call system("open -a ".shellescape(s:termpath)." ".shellescape(l:dir))

), that vim-gtfo always prepends open -a when running a terminal on MacOS. This does not always seem appropriate. For example, I am trying to use kitty (https://sw.kovidgoyal.net/kitty/) as my terminal, however there does not seem to be an option for it (using /Applications/kitty.app) to create a new window in an existing instance - this is only possible by directly using the kitty command in /Applications/kitty.app/Contents/MacOS/kitty. This seems reasonable, but vim-gtfo always expects a GUI-style application open using open -a instead.

It would be great to either remove that or (more likely, since backward-compatibility is likely needed) to support a new type of "OS" - e.g. "macos-noopen".

Happy to create a pull request if you agree.

[justinmk]

Thanks for the note/investigation. I think let g:gtfo#terminals needs to be reworked to be more flexible, probably accepting a lambda or something and not always prepending open ....