Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

ssc init should default to port 1433 #145

Open
Jaxelr opened this issue Feb 11, 2021 · 0 comments
Open

ssc init should default to port 1433 #145

Jaxelr opened this issue Feb 11, 2021 · 0 comments

Comments

@Jaxelr
Copy link
Contributor

Jaxelr commented Feb 11, 2021

Describe the Feature

When running ssc init currently the default value for port is undefined, this causes the field to be NaN on display and Null on creation.

image

As i understand it, it would be a more pleasant UX to default to port 1433, which is the usual sql server default port.

image

Todo

Suggested Solution

The suggested solution is to on line 62 of the init.ts command file switch to 1433 the default value:

default: conn.port || undefined,
message: 'Server port.',
name: 'port',
type: 'number',
when: (answers) => answers.path !== PathChoices.WebConfig,

Other Information

I can make the PR, but i wanted to discuss it first, in case there's some scenarios i am not considering.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant