Move 'Succeeded handling...' log message to JustSaying.Dispatch namespace #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geType} in {TimeToHandle}ms." log message into a JustSaying.Dispatch namespace so it can be ignored separately from other JS messages.
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 83.48% 83.79% +0.30%
==========================================
Files 113 113
Lines 2907 2907
==========================================
+ Hits 2427 2436 +9
+ Misses 480 471 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Maybe it could be Debug? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log message with template
"{Status} handling message with Id '{MessageId}' of type {MessageType} in {TimeToHandle}ms."is new in JS7, and we should allow users to opt out of it by putting it in a separate namespace from everything else that happens in JS. In this PR I've moved it toJustSaying.Dispatch, so that it can be ignored in configuration.This is the only per-message information log event that I can see that's new in JS7, so it's worth making sure we don't hammer our log cluster by accident 😁.
Perhaps this should even be off by default?