[WIP] Unit tests with the new fluent api #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martincostello
changed the title
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@AnthonySteele Are you going to come back to this PR? If not we can close it, then I'll do a PR to shift the code around into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarise the changes this Pull Request makes.
Work towards deprecating the old fluent api and using the new one instead. Trying to port a unit test by building a base class
UnitTestBaseto replaceJustSayingFluentlyTestBase.I found that the
IVerifyAmazonQueuesinstance needs to be injectable.The tests in
WhenAddingASubscriptionHandlerthat are commented out depend on verifying against a mockIAmJustSaying Bus.What equivalent should be mocked, if any? Do these tests still make sense?
Please include a reference to a GitHub issue if appropriate.