Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION WARNING: Using / for division is deprecated #1

Closed
labay11 opened this issue Sep 12, 2021 · 3 comments
Closed

DEPRECATION WARNING: Using / for division is deprecated #1

labay11 opened this issue Sep 12, 2021 · 3 comments

Comments

@labay11
Copy link

labay11 commented Sep 12, 2021

bulma-switch-control: 1.1.1
sass: 1.39.2

[WEBPACK] DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.
[WEBPACK]
[WEBPACK] Recommendation: math.div($switch-width, 2)
[WEBPACK]
[WEBPACK] More info and automated migrator: https://sass-lang.com/d/slash-div
[WEBPACK]
[WEBPACK] ╷
[WEBPACK] 25 │ height: #{$switch-width / 2 + $switch-padding};
[WEBPACK] │ ^^^^^^^^^^^^^^^^^
[WEBPACK] ╵
[WEBPACK] node_modules/bulma-switch-control/scss/_switch.scss 25:17 @import
[WEBPACK] node_modules/bulma-switch-control/bulma-switch-control.scss 3:9 @import

@labay11
Copy link
Author

labay11 commented Dec 29, 2021

As it was done in Bulma#3362, it is sufficient to change the division by a multiplication. In the code, division is only used in lines 25,44 & 45 inside _switch.scss and can be replaced by: #{$switch-width * 0.5 + $switch-padding};

@labay11
Copy link
Author

labay11 commented Feb 6, 2022

Hello @vikdiesel, why did you correctly introduce the change in efaed11 but then you remove it again in cbb1055?

@vikdiesel
Copy link
Contributor

Sorry, there was a mistake. Now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants