-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps)!: update to angular 12 #980
Conversation
fixes #972 BREAKING CHANGE: update to angular 12
Webpack should probably be updated too? |
Webpack is already updated because the dependency to Webpack 5 is contained in the angular package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, hoping this can be merged soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution!
@all-contributors please add @sonallux for code |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Angular 12 is not supported
Issue Number: #972
What is the new behavior?
html-webpack-plugin
in example, because the current version is not compatible with webpack 5Does this PR introduce a breaking change?
Other information