Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@angular-builders/custom-webpack upgrade webpack-merge #819

Closed
andygup opened this issue Aug 23, 2020 · 2 comments
Closed

@angular-builders/custom-webpack upgrade webpack-merge #819

andygup opened this issue Aug 23, 2020 · 2 comments
Labels
breaking-change enhancement New feature or request
Milestone

Comments

@andygup
Copy link

andygup commented Aug 23, 2020

Is your feature request related to a problem? Please describe.
This is a request to upgrade custom-webpack to the latest version of webpack-merge. I did notice this dependabot PR => #814 but couldn't find any related issues.

Describe the solution you'd like
Use regular merge.

Describe alternatives you've considered
With Angular 10, we can run: ng build && webpack --config ./extra-webpack.config.js but that's bypassing the Builder approach and not ideal.

Additional context
We are having merge issues that I suspect might be related to the use of webpack-merge and smartStrategy, reference: https://github.com/just-jeb/angular-builders/blob/master/packages/custom-webpack/src/webpack-config-merger.ts#L2. This is based on 1 year old implementation that's been dropped from the latest version: survivejs/webpack-merge@1c1c2f1

@just-jeb just-jeb added the enhancement New feature or request label Sep 1, 2020
@just-jeb
Copy link
Owner

just-jeb commented Sep 1, 2020

Dropping smartStrategy is a breaking change, so I don't think it can be added as a minor version. It potentially can break a lot of builds, so it should be part of 11 release.

@just-jeb
Copy link
Owner

Closed with #907, you can try it in 11.0.0-beta.2. Refer to the migration guide for the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants