-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(custom-webpack): support ESM #1117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
@eng-dibo I'm not sure if we should add something specific about ESM support in the docs. WDYT? |
Sure, it is a good feature and trendy these days. I see many mega packages updated their docs to mention that it now supports esm. I see you merged the PR but the version in npm still 13.0.0 |
…r-builders into esm-modules-support-hack
as you mentioned in the updated docs, tsconfig-paths doesn't support esm, alternatively there is another one tsc-alias that supports esm and runs in compile time instead of runtime (that gives better performance, but doesn't support runtime modules such as ts-node. I already opened an issue there) usage: |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
A build with
@angular-builders/custom-webpack
builder will fail if ran inside ESM appWhat is the new behavior?
ESM fully supported
Does this PR introduce a breaking change?
Other information
Closes #1101