Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Permission types #7

Merged
merged 3 commits into from
Apr 25, 2018
Merged

Add more Permission types #7

merged 3 commits into from
Apr 25, 2018

Conversation

iAmMrinal0
Copy link
Contributor

Also, use genericShow instead of using a function which converts the types to strings

@iAmMrinal0
Use genericShow instead of pattern match on type of Permission
b7a3ef6 
As the type and their strings are same, it's better to use `genericShow` rather
than increasing redundancy
@iAmMrinal0
Add more Permission types as used by Android
6840e4f 
- Camera
- Location
- Coarse location
- Contacts
@iAmMrinal0
Add PermissionDeclinedForever type to PermissionStatus
15192ec 
Android provides the user to decline the permission forever and having a type
for that helps us in identifying what the user selected and what to do in such a case
@dilipzotha dilipzotha merged commit 383a4a8 into juspay:master Apr 25, 2018
@iAmMrinal0 iAmMrinal0 deleted the feature/addMorePermissions branch June 6, 2018 09:39
belevy pushed a commit to belevy/purescript-presto that referenced this pull request Apr 17, 2023
@JamesGeorg
Merged in revertDeps (pull request juspay#7)
e45178a 
Revert foreign-generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilipzotha dilipzotha dilipzotha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iAmMrinal0 @dilipzotha