Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(connector-sanity-tests): run tests on being queued for merge #960

Merged
merged 1 commit into from
Apr 24, 2023
Merged

ci(connector-sanity-tests): run tests on being queued for merge #960

merged 1 commit into from
Apr 24, 2023

Conversation

SanchithHegde
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR updates the connector sanity tests workflow to be run on being added to merge queue instead of on PRs being opened/updated.

Motivation and Context

This would prevent the connector sanity tests from failing on PRs by external contributors because of a missing secret, and hopefully reduce confusion as to why their tests are failing.

How did you test it?

This PR should not have the connector sanity tests among the PR checks.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SanchithHegde SanchithHegde added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 22, 2023
@SanchithHegde SanchithHegde requested a review from a team as a code owner April 22, 2023 12:54
@SanchithHegde SanchithHegde self-assigned this Apr 22, 2023
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-ready-for-merge S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 24, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Apr 24, 2023
@jarnura jarnura removed the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Apr 24, 2023
@jarnura jarnura added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit 067dc70 Apr 24, 2023
@SanchithHegde SanchithHegde deleted the ci-connector-tests-on-merge-queue branch April 24, 2023 20:05
@NishantJoshi00 NishantJoshi00 mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@lsampras lsampras lsampras approved these changes

Assignees

@SanchithHegde SanchithHegde

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanchithHegde @jarnura @lsampras