Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stripe): add setup intent sync for stripe #953

Merged
merged 5 commits into from
Apr 24, 2023
Merged

fix(stripe): add setup intent sync for stripe #953

merged 5 commits into from
Apr 24, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This fixes the basic setup intent behaviour and adds functionality to allow setup intent sync.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 added A-connector-integration Area: Connector integration A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 21, 2023
@NishantJoshi00 NishantJoshi00 self-assigned this Apr 21, 2023
Narayanbhat166
Narayanbhat166 previously approved these changes Apr 21, 2023
View reviewed changes
Narayanbhat166
Narayanbhat166 previously approved these changes Apr 21, 2023
View reviewed changes
Abhicodes-crypto
Abhicodes-crypto previously approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional changes suggested. Other than that LGTM.

@jarnura jarnura removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 24, 2023
@jarnura jarnura added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit ab7fc23 Apr 24, 2023
@SanchithHegde SanchithHegde deleted the fix/si-sync branch April 24, 2023 20:03
@NishantJoshi00 NishantJoshi00 mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@jagan-jaya jagan-jaya Awaiting requested review from jagan-jaya

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NishantJoshi00 @jarnura @Narayanbhat166 @Abhicodes-crypto @SanchithHegde