fix(connector-template): Address unused import and mismatched types in connector-template #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When
add_connector.sh
is called to generate new connector filesmod.rs
had an unused declaration, removed it. At the time of development, if needed, one can import it directly instead of pre-bloating the stuff.Transformers.rs
straight away failed and threw an error addressingmismatched types
as it is expectingbool
while were providingResult<bool, Error>
.Additional Changes
connector-template/mod.rs
connector-template/transformers.rs
Motivation and Context
With the changes made, unexpected errors and warnings at the time of generation of connector code is avoided and addressed.
Checklist
cargo +nightly fmt --all
cargo clippy