Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-template): Address unused import and mismatched types in connector-template #910

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

pixincreate
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

When add_connector.sh is called to generate new connector files mod.rs had an unused declaration, removed it. At the time of development, if needed, one can import it directly instead of pre-bloating the stuff.
Transformers.rs straight away failed and threw an error addressing mismatched types as it is expecting bool while were providing Result<bool, Error>.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

connector-template/mod.rs
connector-template/transformers.rs

Motivation and Context

With the changes made, unexpected errors and warnings at the time of generation of connector code is avoided and addressed.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@pixincreate pixincreate added the C-refactor Category: Refactor label Apr 18, 2023
@pixincreate pixincreate self-assigned this Apr 18, 2023
@pixincreate pixincreate requested review from ArjunKarthik and dracarys18 and removed request for ArjunKarthik April 19, 2023 09:46
dracarys18
dracarys18 previously approved these changes Apr 19, 2023
@pixincreate pixincreate changed the title Address unused import and mismatched types in connector-template fix(template): Address unused import and mismatched types in connector-template Apr 19, 2023
@pixincreate pixincreate added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 20, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 20, 2023
@ArjunKarthik ArjunKarthik changed the title fix(template): Address unused import and mismatched types in connector-template fix(connector-template): Address unused import and mismatched types in connector-template Apr 20, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 891683e Apr 20, 2023
@pixincreate pixincreate deleted the add_connector_fix branch April 21, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants