Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add relevant ids for payment calls & make json logs #908

Merged
merged 3 commits into from
Apr 20, 2023
Merged

feat: add relevant ids for payment calls & make json logs #908

merged 3 commits into from
Apr 20, 2023

Conversation

NishantJoshi00
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

The PR introduces 2 changes

  • Adds payment_id and merchant_id for any payment_core call
  • putting start/end span json log events under feature flag, (currently set to disabled)

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@NishantJoshi00 NishantJoshi00 self-assigned this Apr 18, 2023
@NishantJoshi00 NishantJoshi00 requested review from a team as code owners April 18, 2023 12:41
@NishantJoshi00 NishantJoshi00 added A-framework Area: Framework A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 18, 2023
@NishantJoshi00
Copy link
Member Author

NishantJoshi00 commented Apr 18, 2023 •
edited
Loading

Pending questions:

  • should entry/exit span logs be present in sandbox/production?

vspecky
vspecky requested changes Apr 19, 2023
View reviewed changes
crates/router/src/core/payments.rs Outdated Show resolved Hide resolved
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 19, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 93b69e7 Apr 20, 2023
@SanchithHegde SanchithHegde deleted the feat/field-capture-logs branch April 21, 2023 05:00
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vspecky vspecky vspecky approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@lsampras lsampras lsampras approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@NishantJoshi00 NishantJoshi00

Labels
A-core Area: Core flows A-framework Area: Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NishantJoshi00 @jarnura @lsampras @SanchithHegde @vspecky