-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): [Stripe] add bank debits payment method to stripe #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narayanbhat166
added
A-connector-compatibility
Area: Connector compatibility
A-core
Area: Core flows
M-api-contract-changes
Metadata: This PR involves API contract changes
labels
Apr 18, 2023
Narayanbhat166
requested review from
jagan-jaya and
Abhicodes-crypto
and removed request for
Abhicodes-crypto
April 19, 2023 07:20
Narayanbhat166
added
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Apr 19, 2023
Abhicodes-crypto
previously approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jarnura
requested changes
Apr 20, 2023
jarnura
added
the
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
label
Apr 20, 2023
Narayanbhat166
added
A-payment-methods
Area: Payment Methods
and removed
A-connector-compatibility
Area: Connector compatibility
A-core
Area: Core flows
labels
Apr 20, 2023
Narayanbhat166
force-pushed
the
feat/bank_debits
branch
from
April 20, 2023 10:43
e577dec
to
deee456
Compare
Narayanbhat166
added
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
and removed
S-waiting-on-author
Status: This PR is incomplete or needs to address review comments
labels
Apr 20, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 20, 2023
jarnura
previously approved these changes
Apr 20, 2023
Narayanbhat166
force-pushed
the
feat/bank_debits
branch
from
April 21, 2023 06:32
abff206
to
932eb31
Compare
jarnura
approved these changes
Apr 21, 2023
jarnura
added
the
S-waiting-on-approval
Status: Review completed, awaiting for approvals from code-owners
label
Apr 21, 2023
Abhicodes-crypto
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jarnura
removed
the
S-waiting-on-approval
Status: Review completed, awaiting for approvals from code-owners
label
Apr 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Apr 21, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-payment-methods
Area: Payment Methods
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR will add support for creating payments using
bank_debits
payment method. This has been implemented for stripe.Mandate details have to passed for all the payment methods.
merchant_connector_account
withbusiness_country
asUS
.merchant_connector_account
in any country of the EU region, example "FR".merchant_connector_account
inAU
region.Motivation and Context
To support
bank_debits
payment method for anyone to use. Closes #838How did you test it?
- Microdeposit verification for ACH
Bacs bank debit
The payment goes to
requires_action
. This requires some options to be enabled in stripe account.Becs bank debit
Checklist
cargo +nightly fmt --all
cargo clippy