Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): added dispute accept api, file module apis and dispute evidence submission api #900

Merged
merged 71 commits into from
Apr 24, 2023
Merged

feat(router): added dispute accept api, file module apis and dispute evidence submission api #900

merged 71 commits into from
Apr 24, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

@sai-harsha-vardhan sai-harsha-vardhan commented Apr 17, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Added support for following APIs

  1. Dispute Accept API - To accept the dispute with connector.
  2. File Upload API - Validate and Upload a file.
  3. File Retrieve API - Download a file using file id.
  4. File Delete API - Delete a file using file id.
  5. Dispute Evidence Submission API - Submitting the evidences to connector using file ids.

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually

Dispute Accept API - 2xx
image

Dispute Accept API - 4xx
image

File Upload API
image

File Retrieve API
image

File Delete API
image

File Metadata Schema in DB
image

Submit Evidence API - 2xx
image

Submit Evidence API - 4xx
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Sangamesh26 and others added 30 commits February 9, 2023 16:02
@Sangamesh26
api contract for bank redirect
e05d385
@Sangamesh26
contract change for sofort
b31bb01
@Sangamesh26
changed in migration for payment_method from type to varchar
f95cec3
Initial commit
b078ab6
Merge branch 'bank-redirect-api-contract' of https://github.com/juspa…
bd03936 
…y/hyperswitch into feat/add_connector_trustpay
Added bank transfers
f17ef01
Added refunds and refund sync for trustpay
8d86767
Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…
503cf0f 
…t/add_connector_trustpay
added trustpay refunds, refundsync
f8cee46
Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…
6471368 
…t/add_connector_trustpay
added tests for trustpay
05bab31
revered unnecessary changes
16833ba
reverted unnecessary changes
ccb1639
Refactoring and resolved comments
610a45c
Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…
9109e80 
…t/add_connector_trustpay
Refactor and resolving comments
8b4e07f
resolved comments
bd8ebe0
resolved comments
f93a808
@jarnura
Merge branch 'main' into feat/add_connector_trustpay
247ec86
added rsync for bank redirects
2e76e6b
fixed bank redirect sync, refund sync and resolved comments
822b92e
Merge branch 'feat/add_connector_trustpay' of https://github.com/jusp…
d7ffed3 
…ay/hyperswitch into feat/add_connector_trustpay
refactored and resolved comments
a6bf5d6
Merge branch 'main' of https://github.com/juspay/hyperswitch into fea…
b05a0c3 
…t/add_connector_trustpay
resolved comments
273e0bb
added webhooks for trustpay
d439e93
added signature verification for trustpay webhooks
17982b1
merged main
a4d8888
removed unnecessary changes
f7d9bdb
resolved comments
f2cfd8e
vspecky
vspecky previously approved these changes Apr 21, 2023
View reviewed changes
jarnura
jarnura requested changes Apr 21, 2023
View reviewed changes
migrations/2023-04-04-061926_add_dispute_api_schema/up.sql Outdated Show resolved Hide resolved
crates/router/src/routes/files/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/files/s3_utils.rs Outdated Show resolved Hide resolved
crates/router/src/core/files/s3_utils.rs Outdated Show resolved Hide resolved
crates/router/src/core/files/helpers.rs Outdated Show resolved Hide resolved
crates/router/src/core/files.rs Outdated Show resolved Hide resolved
crates/router/src/core/disputes.rs Outdated Show resolved Hide resolved
crates/router/src/core/disputes.rs Outdated Show resolved Hide resolved
crates/router/src/core/disputes.rs Outdated Show resolved Hide resolved
crates/router/src/core/disputes.rs Outdated Show resolved Hide resolved
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 21, 2023
@sai-harsha-vardhan sai-harsha-vardhan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 21, 2023
jarnura
jarnura requested changes Apr 24, 2023
View reviewed changes
crates/router/src/routes/files/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/routes/files/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/core/files/fs_utils.rs Outdated Show resolved Hide resolved
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 24, 2023
@sai-harsha-vardhan sai-harsha-vardhan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 24, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 24, 2023
@jarnura jarnura added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit bdf1e51 Apr 24, 2023
@SanchithHegde SanchithHegde deleted the feat/dispute-evidence-apis branch April 24, 2023 20:04
lsampras
lsampras reviewed Apr 25, 2023
View reviewed changes
config/development.toml
Comment on lines +189 to +192
[file_upload_config]
bucket_name = ""
region = ""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add this fields to other config.example.toml & docker_compose.toml

@sai-harsha-vardhan

@NishantJoshi00 NishantJoshi00 mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto left review comments

@lsampras lsampras lsampras left review comments

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@vspecky vspecky vspecky approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-api-contract-changes Metadata: This PR involves API contract changes M-configuration-changes Metadata: This PR involves configuration changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sai-harsha-vardhan @SanchithHegde @Narayanbhat166 @jarnura @lsampras @vspecky @Abhicodes-crypto @Sangamesh26