Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Checkout] add GooglePay, ApplePay and Webhooks support #875

Merged
merged 14 commits into from
Apr 20, 2023
Merged

feat(connector): [Checkout] add GooglePay, ApplePay and Webhooks support #875

merged 14 commits into from
Apr 20, 2023

Conversation

SamraatBansal
Copy link
Contributor

@SamraatBansal SamraatBansal commented Apr 13, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

  • Added Wallets ( GooglePay, ApplePay ) and Webhooks support for checkout
  • Introduced tokenization and then called the respective endpoint to make wallet payment GooglePay, ApplePay
  • Payments, Refunds, Disputes Webhooks are integrated

Additional Changes

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

The Authentication Type for Checkout has been changed to SignatureKey to accommodate additional key for tokenization of wallet_data.
Encrypted secret file is also being pushed along to accommodate the change for sanity tests.

Motivation and Context

Closes #916

How did you test it?

Introduced all the basic unit tests, Rsync is ignored as it is throwing error from connector side although working in Postman.

ApplePay is not tested due to token availability issue.

Screenshot 2023-04-13 at 4 38 36 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 13, 2023
@SamraatBansal SamraatBansal self-assigned this Apr 13, 2023
@jarnura jarnura added this to the April'23 release milestone Apr 14, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 17, 2023
@SamraatBansal SamraatBansal added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Apr 17, 2023
ArjunKarthik
ArjunKarthik previously approved these changes Apr 17, 2023
View reviewed changes
jagan-jaya
jagan-jaya previously approved these changes Apr 17, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik previously approved these changes Apr 17, 2023
View reviewed changes
jagan-jaya
jagan-jaya previously approved these changes Apr 18, 2023
View reviewed changes
@SamraatBansal SamraatBansal added S-ready-for-merge and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Apr 18, 2023
jagan-jaya
jagan-jaya previously approved these changes Apr 18, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik previously approved these changes Apr 18, 2023
View reviewed changes
@manojradhakrishnan manojradhakrishnan mentioned this pull request Apr 19, 2023
Closed
7 tasks
@SamraatBansal SamraatBansal added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-ready-for-merge labels Apr 19, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 19, 2023
@jarnura jarnura added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit 3fce140 Apr 20, 2023
@SanchithHegde SanchithHegde deleted the checkout-wallet-integration branch April 21, 2023 04:59
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixincreate pixincreate pixincreate left review comments

@jarnura jarnura jarnura approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@jagan-jaya jagan-jaya jagan-jaya approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
April 2023 Release
Development

Successfully merging this pull request may close these issues.

[FEATURE] Checkout.com support for Applepay, Googlepay and Webhooks
6 participants
@SamraatBansal @jagan-jaya @ArjunKarthik @jarnura @pixincreate @SanchithHegde