feat: support gpay and applepay session response for all connectors #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangamesh26
added
A-core
jarnura
requested changes
Apr 5, 2023
jarnura
added
the
S-waiting-on-author
Sangamesh26
removed
the
S-waiting-on-author
jarnura
previously approved these changes
Apr 6, 2023
Narayanbhat166
requested changes
Apr 6, 2023
Narayanbhat166
requested changes
Apr 12, 2023
Narayanbhat166
requested changes
Apr 13, 2023
Narayanbhat166
previously approved these changes
Apr 18, 2023
jarnura
requested changes
Apr 19, 2023
jarnura
added
S-waiting-on-author
Sangamesh26
added
S-waiting-on-review
jarnura
approved these changes
Apr 20, 2023
Narayanbhat166
approved these changes
Apr 20, 2023
jarnura
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Earlier session token for gpay was only supported for Adyen and applepay for Applepay as connector.So, now gpay and applepay session token is supported by all the connectors which enable them as payment_methods.
Removed Applepay as a connector and get the response from applepay server in the session_flow itself. Ideally Applepay should not be treated as a connector, it was earlier hided in dashboard by some filters in the dashboard side.
Motivation and Context
Support applepay and gpay for all connectors which enable them as payment_methods for session_token.
How did you test it?
Manual
Checklist
cargo +nightly fmt --allcargo clippy