Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump empack #126

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Bump empack #126

merged 1 commit into from
Oct 23, 2024

Conversation

trungleduc
Copy link
Collaborator

No description provided.

martinRenou
martinRenou approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Member

CI failures look legit:


    def write_minimal_conda_meta(pkg_meta, env_prefix):
>       content = {k: pkg_meta[k] for k in ["name", "version", "build", "build_number", "url"]}
E       KeyError: 'url'

../../../../micromamba/envs/xeus-lite-dev/lib/python3.12/site-packages/empack/filter_env.py:76: KeyError

@martinRenou
Copy link
Member

I'm thankful we made a major release of empack!

@trungleduc
Copy link
Collaborator Author

fixed in emscripten-forge/empack#110

@martinRenou martinRenou reopened this Oct 23, 2024
@trungleduc
Copy link
Collaborator Author

it's green

martinRenou
martinRenou approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 473ab8b into jupyterlite:main Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou