-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use coincident
if crossOriginIsolated
, comlink
otherwise
#108
Conversation
Looks like the use of |
@jtpio this should be ready now. Would you be able to have another look? |
@jtpio thanks for your review! I added the comment as you suggested, will go ahead and make a release with this |
It would also have been nice to mention this change in the changelog for visibility: https://jupyterlite-xeus.readthedocs.io/en/latest/changelog.html For the docs, there is already some content https://jupyterlite.readthedocs.io/en/stable/howto/content/python.html we could link to. |
Similar to jupyterlite/pyodide-kernel#126
Refactor the code to align the implementation on https://github.com/jupyterlite/pyodide-kernel, so it's easier to switch between the code bases and find the same patterns.
Fixes #102