Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coincident if crossOriginIsolated, comlink otherwise #108

Merged
merged 12 commits into from
Sep 9, 2024

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 16, 2024

Similar to jupyterlite/pyodide-kernel#126

Refactor the code to align the implementation on https://github.com/jupyterlite/pyodide-kernel, so it's easier to switch between the code bases and find the same patterns.

Fixes #102

@jtpio
Copy link
Member Author

jtpio commented Aug 16, 2024

Looks like the use of postMessage in xeus-lite may need some investigation: https://github.com/jupyter-xeus/xeus-lite/blob/b1c9e1fd29caa88e7ebb2dd06c798c248ed01b0c/src/xserver_emscripten.cpp#L24-L32

@martinRenou martinRenou marked this pull request as ready for review September 9, 2024 11:45
@martinRenou
Copy link
Member

@jtpio this should be ready now. Would you be able to have another look?

@martinRenou
Copy link
Member

@jtpio thanks for your review! I added the comment as you suggested, will go ahead and make a release with this

@martinRenou martinRenou merged commit 44b9acb into jupyterlite:main Sep 9, 2024
13 checks passed
@jtpio jtpio deleted the comlink branch September 9, 2024 15:04
@jtpio
Copy link
Member Author

jtpio commented Sep 10, 2024

It would also have been nice to mention this change in the changelog for visibility: https://jupyterlite-xeus.readthedocs.io/en/latest/changelog.html

For the docs, there is already some content https://jupyterlite.readthedocs.io/en/stable/howto/content/python.html we could link to.

@jtpio jtpio mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use coincident if crossOriginIsolated, comlink otherwise
2 participants