-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate further startup time improvements #14
Comments
I saw a comment like this in jupyterlite/jupyterlite#911 as well, but unless I'm misunderstanding how |
Right, iirc even code like the following would trigger the install? if False:
import matplotlib |
Right: unless it's made optional upstream in
This would theoretically be something we could hoist up to lite plugin settings, e.g. "jupyter-config-data": {
"litePluginSettings": {
"@jupyterlite/pyolite-kernel-extension:kernel": {
"disablePyPIFallback": true,
"repodata": {
"jedi": null
}
}
}
} this would then allow |
Yes, I think it purely, statically looks for |
I think the only reason you install |
Right, but 99% of the time, the user wants that feature. |
Yes, that's why I just remove |
Right, except this is for the kernel itself, so there are some timing issues. We further allow folk to use a custom pyodide, and don't/won't ship all 200mb. Typically if we do some hack like this, we try to make it useful for downstreams as well (this is why we have |
While I was thinking this over:
This wouldn't change the public API at all, and notebooks would still have to |
Update to pyodide 0.22.1, use NodeJS 18 LTS
Problem
pyodide_kernel
requires many packages to be fully downloaded (if not already cached) and installed before giving the user the ability to do interactive computing.Proposed Solution
Investigate additional packages which could be avoided, either by shim or patch.
Additional context
With jupyterlite/jupyterlite#913, we'd be down to 724 modules.
A standout are the 97
jedi
andparso
packages: at present,jedi
integration is turned off, presumably as it is so slow as to appear broken. At any rate, we're still paying 1.7mb on the wire to download these two packages.As
jedi
is part of the pyodide standard distribution it may be rather hacky to work around it getting installed, due to issues like jupyterlite/jupyterlite#904, but may be worth it for doign 10% less work for... nothing.The text was updated successfully, but these errors were encountered: