-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add team-compass page including JupyterLab Council members #139
Conversation
@afshin I may miss context. How is the list of contributors related to commit rights? |
@echarles I think the file name is legacy from where I copied it, but there isn't a strict relationship between commit rights and membership in the JupyterLab Council. At some point when the Council is fully set up it might be a 1:1 relationship but for the process of ramping up, there will likely be many more people with commit rights than there are members of the JupyterLab Council. |
Just to be clearer: that file in this PR is not the list of contributors for JupyterLab by any stretch 😂 |
@@ -0,0 +1,105 @@ | |||
(membership_guidelines)= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of mentions of "team" in this file that should be changed to "council". Also, it would be great to change the directory of these files from "team" to "council" if these are all about the council.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are a few mentions of "team" that should mean the wider community of people. And there are some places where "team member" should just be "member". But I do think we should retain some usage of the term "team" because this is, after all, the team-compass
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I do think we should retain some usage of the term "team" because this is, after all, the
team-compass
.
Yes, absolutely!
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
@afshin this is looking good, thanks for setting that up! Do you think this is ready to be merged, so it can be iterated on as new members are added to the council? |
@jtpio yeah, I think so. At first, I was hoping that we would synchronize with https://github.com/jupyter/team-compass-template but actually iterating seems better than leaving this open forever. |
We could add the following to the
Otherwise it looks good and should be good to go! |
Added in 151e0de. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Let's get that one in and iterate. Follow-up actions:
- making sure the project exists on ReadTheDocs
- enable the ReadTheDocs preview for pull requests
This comment was marked as duplicate.
This comment was marked as duplicate.
The site is now live on ReadTheDocs: https://jupyterlab-team-compass.readthedocs.io/en/latest/ |
I copied @Zsailer's lead in setting up the Jupyter Notebook page. However, there are a few notable differences and I would really appreciate reviews on this: