Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Remove the manual @jupyterlab/notebook-extension:panel settings fetch #325

Closed
jtpio opened this issue Jan 21, 2022 · 0 comments · Fixed by #352
Closed

Remove the manual @jupyterlab/notebook-extension:panel settings fetch #325

jtpio opened this issue Jan 21, 2022 · 0 comments · Fixed by #352
Labels
bug Something isn't working
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Jan 21, 2022

Description

In #319 we added the following logic to ensure the settings-defined toolbar items are correctly retrieved before creating a new notebook panel and adding it to the main area:

await settingRegistry?.load('@jupyterlab/notebook-extension:panel');
await Promise.resolve();

Expected behavior

Downstream distributions and extensions should ideally not have to explicit use that workaround.

Context

Noticed in #319

Allow extensions and users to customize easily toolbar items upstream PR: jupyterlab/jupyterlab#10469

The JupyterLab tests do something similar:

https://github.com/jupyterlab/jupyterlab/blob/50fa0047d63287005a2c3b1d8f5bfedfe56cde7e/packages/apputils/test/toolbar.spec.ts#L304-L308

@jtpio jtpio added the bug Something isn't working label Jan 21, 2022
@jtpio jtpio added this to the 0.4.0 milestone Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant