Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Drop the Retro Logo #305

Closed
jtpio opened this issue Dec 16, 2021 · 0 comments · Fixed by #324
Closed

Drop the Retro Logo #305

jtpio opened this issue Dec 16, 2021 · 0 comments · Fixed by #324
Labels

Comments

@jtpio
Copy link
Member

jtpio commented Dec 16, 2021

Problem

As we make progress towards RetroLab becoming Notebook 7, we should consider dropping the RetroLab logo, which can be enabled here:

retrolab/retrolab/app.py

Lines 203 to 205 in 1ad349a

retro_logo = Bool(
False, config=True, help="Whether to use the RetroLab inline logo."
)

Proposed Solution

We remove support for the retro logo here:

retrolab/retrolab/app.py

Lines 203 to 205 in 1ad349a

retro_logo = Bool(
False, config=True, help="Whether to use the RetroLab inline logo."
)

And the handling of that option here:

const retroLogo = PageConfig.getOption('retroLogo') === 'true';
const icon = retroLogo ? retroInlineIcon : jupyterIcon;

Additional context

This was originally added in #131.

So the logo would be displayed in the top area:

logo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant