Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Add more UI tests #228

Closed
jtpio opened this issue Sep 21, 2021 · 3 comments
Closed

Add more UI tests #228

jtpio opened this issue Sep 21, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 21, 2021

Problem

For now there are a couple of UI tests running on both chromium and firefox.

They are useful as basic smoke tests, and to check RetroLab opens activities in new browser tabs.

We should cover more features specific to RetroLab in these tests.

Proposed Solution

The existing end to end tests are located in this folder: https://github.com/jupyterlab/retrolab/tree/main/app/test

We could follow the galata setup in JupyterLab: https://github.com/jupyterlab/jupyterlab/tree/master/galata

And try to use Galata with Retro, or stick to plain Playwright like it is now.

Additional context

This could help catch regressions like #226.

@jtpio jtpio added the enhancement New feature or request label Sep 21, 2021
@jtpio jtpio added this to the Future milestone Sep 21, 2021
@jtpio
Copy link
Member Author

jtpio commented Oct 9, 2021

These tests could cover:

@jtpio jtpio added the help wanted Extra attention is needed label Oct 30, 2021
@jtpio
Copy link
Member Author

jtpio commented Oct 30, 2021

This will also be useful to catch missing plugins from upstream when we update to newer packages, like in #263

@jtpio
Copy link
Member Author

jtpio commented Apr 4, 2022

Closing in favor of jupyter/notebook#6322

@jtpio jtpio closed this as completed Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant